add Group Channel adaptations on apps #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

plebhash wants to merge 17 commits into stratum-mining:main from plebhash:2025-12-18-adapt-group-channels

Member

plebhash commented Dec 24, 2025 •

edited

Loading

close #146 #140

companion to stratum-mining/stratum#2044

plebhash changed the title ~~add Group Channel adaptations on apps~~ add Group Channel adaptations on apps 🎅

This was referenced Dec 24, 2025

add Group Channel adaptations on channels_sv2 + mining_sv2 stratum-mining/stratum#2044

Open

aggregated tProxy sends multiple OpenExtendedMiningChannel messages if clients connect too fast #157

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 4a0fa49 to c7b55c2 Compare

December 28, 2025 01:16

plebhash changed the title ~~add Group Channel adaptations on apps 🎅~~ add Group Channel adaptations on apps

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from c7b55c2 to 6a9c060 Compare

December 28, 2025 20:29

plebhash mentioned this pull request

tProxy: consider renaming upstream_extended_channel to aggregated_extended_channel #158

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 5 times, most recently from d61670c to b907454 Compare

December 29, 2025 17:33

Member Author

plebhash commented Dec 29, 2025

@lucasbalieiro can you please do some testing with the changes from this PR + stratum-mining/stratum#2044?

please make sure you cover:

no JD + tProxy in aggregated + at least 2 cpu miners
no JD + tProxy in non-aggregated + at least 2 cpu miners
JD + tProxy in non-aggregated + at least 2 cpu miners

Contributor

lucasbalieiro commented Dec 29, 2025

@lucasbalieiro can you please do some testing with the changes from this PR + stratum-mining/stratum#2044?

please make sure you cover:

no JD + tProxy in aggregated + at least 2 cpu miners

no JD + tProxy in non-aggregated + at least 2 cpu miners

JD + tProxy in non-aggregated + at least 2 cpu miners

Working on It

Contributor

lucasbalieiro commented Jan 2, 2026 •

edited

Loading

I was able to do some testing mine some blocks, see if it open more channels than necessary upstream and seems to be working fine. With all the scenarios that you suggested.

I was not able to do longer testing sessions because I need the patch from #138 for my setup to behave better

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/mod.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Show resolved Hide resolved

Shourya742 reviewed

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/data.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

Shourya742 reviewed

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 2 times, most recently from 0e7f266 to bfa7769 Compare

January 16, 2026 16:08


          Pool always groups extended channels

3f12f29

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 3 times, most recently from 11eac5f to 142e659 Compare

January 16, 2026 17:33

plebhash added 15 commits

January 16, 2026 15:37


          tProxy handles Group Channels

0f5162f


          JDC always groups extended channels

8bddc81


          add hex dependency to integration_test_sv2

d78d458


          pool_does_not_send_jobs_to_jdc Integration Test also ignores SetNewPr…

243b1e8

…evHash


          add pool_group_extended_channels Integration Test

e21377e


          add jdc_group_extended_channels Integration Test

a015784


          add pool_group_standard_channels Integration Test

eb7f8c3


          add jdc_group_standard_channels Integration Test

09313b6


          add pool_require_standard_jobs_set_does_not_group_standard_channels I…

dd84593

…ntegration Test


          add jdc_require_standard_jobs_set_does_not_group_standard_channels In…

b540ec0

…tegration Test


          add aggregated_translator_correctly_deals_with_group_channels Integra…

81b23c1

…tion Test


          add non_aggregated_translator_correctly_deals_with_group_channels Int…

6190efc

…egration Test


          add non_aggregated_translator_handles_set_group_channel_message Integ…

8c80d8d

…ration Test


          add non_aggregated_translator_correctly_deals_with_close_channel_message

1f924ad


          add aggregated_translator_triggers_fallback_on_close_channel_message

9c0b0b5

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 142e659 to 9c0b0b5 Compare

January 16, 2026 18:37

plebhash mentioned this pull request

tProxy: introduce global AGGREGATION_MODE variable #185

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 2 times, most recently from a3ffbde to 9b2c92b Compare

January 17, 2026 17:32


          add HashMap of prevhashes in Sv1ServerData

7d26ebb

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 9b2c92b to 7d26ebb Compare

January 17, 2026 17:36

plebhash mentioned this pull request

improve non_aggregated_translator_correctly_deals_with_group_channels with wait_and_assert #188

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet